Conversation
…gaps, test markers Three workstreams implemented in parallel: 1. Security hardening (SSC-3 + SSC-6): - YAML document-size limit (10 MB) in generic and STPA adapters - Dashboard default bind to 127.0.0.1 (warns on 0.0.0.0) - 2 new unit tests for size limit enforcement 2. Dashboard filter/sort/pagination: - /artifacts: ?types=, ?q=, ?sort=, ?dir=, ?per_page=, ?page= - Filter bar with search input, type dropdown, per-page selector - Sortable column headers with direction arrows - Windowed pagination with prev/next/ellipsis - /stpa: filter bar with type checkboxes and text search - All href values match hx-get (no href="#") 3. V-model traceability: - FEAT-016 now satisfies REQ-003 (ASPICE V-model) - FEAT-014 now satisfies REQ-009 (test results evidence) - DD-039 created for REQ-022 (asset embedding rationale) - 324 `// rivet: verifies REQ-XXX` markers added across 22 source files Validate: PASS 0 warnings. All tests pass. Implements: FEAT-065 Satisfies: REQ-012 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: c5c28da | Previous: c1886da | Ratio |
|---|---|---|---|
link_graph_build/10000 |
42409249 ns/iter (± 17628456) |
28349124 ns/iter (± 2377978) |
1.50 |
validate/10000 |
11589341 ns/iter (± 3016998) |
5107676 ns/iter (± 473444) |
2.27 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
// rivet: verifiesmarkers across 22 source filesTest plan
rivet validatePASS 0 warnings🤖 Generated with Claude Code